-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
WEB/CI: Use GITHUB_TOKEN when making Github API calls #50837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wouldn't you have to expose the token using a pandas/.github/workflows/ubuntu.yml Lines 177 to 178 in 3d89931
I doubt that the GITHUB_TOKEN would be directly accessible without doing it (IIRC secrets are encrypted). |
It's already here
|
Ah, makes sense. Sorry for the noise. |
Sorry to remove that, I assumed it was to fix the quota problem, and that it didn't work. What is this doing? Is it increasing the quota, or something else? |
Yeah I think authenticating with the GIthub Token bumps up our requests/hour (but is still limited) https://docs.github.com/en/rest/overview/resources-in-the-rest-api?apiVersion=2022-11-28#rate-limits-for-requests-from-github-actions |
Did you check if the token is working as expected? I see github send some headers with the limits: https://docs.github.com/en/rest/overview/resources-in-the-rest-api?apiVersion=2022-11-28#rate-limit-headers We should have quota for more than 20 web builds per hour with the 1,000 limit (not considering we were caching most of them in theory), and it felt that the CI was failing pretty quickly anyway. Since secrets aren't available for PRs, only for commits, I guess this may be indeed helping the commit builds, the ones that are deployed and really matter. Not sure if the failures I saw were mainly PRs. |
Follow up to #50811, might as well still make authenticated API calls to Github